Re: [PATCH v1 03/17] thermal: Remove debug or error messages in get_temp() ops
From: Miquel Raynal
Date: Mon Feb 20 2023 - 03:58:49 EST
Hi Daniel,
daniel.lezcano@xxxxxxxxxx wrote on Sun, 19 Feb 2023 15:36:43 +0100:
> Some get_temp() ops implementation are showing an error or a debug
> message if the reading of the sensor fails.
>
> The debug message is already displayed from the call site of this
> ops. So we can remove it.
>
> On the other side, the error should not be displayed because in
> production that can raise tons of messages.
>
> Finally, some drivers are showing a debug message with the
> temperature, this is also accessible through the trace from the core
> code in the temperature_update() function.
>
> Another benefit is the dev_* messages are accessing the thermal zone
> device field from the structure, so we encapsulate even more the code
> by preventing these accesses.
>
> Remove those messages.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> ---
> drivers/thermal/armada_thermal.c | 10 ++--------
For Armada:
Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
Thanks,
Miquèl