[PATCH v3 net-next 01/13] net: ethtool: fix __ethtool_dev_mm_supported() implementation
From: Vladimir Oltean
Date: Mon Feb 20 2023 - 07:24:08 EST
The MAC Merge layer is supported when ops->get_mm() returns 0.
The implementation was changed during review, and in this process, a bug
was introduced.
Link: https://lore.kernel.org/netdev/20230111161706.1465242-5-vladimir.oltean@xxxxxxx/
Fixes: 04692c9020b7 ("net: ethtool: netlink: retrieve stats from multiple sources (eMAC, pMAC)")
Signed-off-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
Reviewed-by: Ferenc Fejes <fejes@xxxxxxxxxxx>
---
v2->v3: change link from patchwork to lore
v1->v2: none
net/ethtool/mm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ethtool/mm.c b/net/ethtool/mm.c
index e612856eed8c..fce3cc2734f9 100644
--- a/net/ethtool/mm.c
+++ b/net/ethtool/mm.c
@@ -247,5 +247,5 @@ bool __ethtool_dev_mm_supported(struct net_device *dev)
if (ops && ops->get_mm)
ret = ops->get_mm(dev, &state);
- return !!ret;
+ return !ret;
}
--
2.34.1