Re: [PATCH v2 4/5] dt-bindings: mmc: sdhci-cadence: SD6 support
From: Krzysztof Kozlowski
Date: Mon Feb 20 2023 - 08:49:16 EST
On 20/02/2023 14:22, Piyush Malgujar wrote:
>>> +
>>> + cdns,read-dqs-cmd-delay:
>>> + description: Command delay used in HS200 tuning
>>
>> What are the units?
>>
>>> + $ref: "/schemas/types.yaml#/definitions/uint32"
>>
>> Drop quotes (everywhere)
>>
>>> +
>>> + cdns,tune-val-start:
>>> + description: Staring value of data delay used in HS200 tuning
>>
>> Same problem - missing units.
>>
>
> These are integer values, will add in the description that these units are integer used
> in tuning. Also, will remove the $ref.
All units are integer values. We don't talk about this. Delay is usually
in time, thus I would assume here proper unit suffix.
Best regards,
Krzysztof