Re: [PATCH net-next v1 3/4] net: phy: do not force EEE support
From: Russell King (Oracle)
Date: Mon Feb 20 2023 - 09:21:53 EST
On Mon, Feb 20, 2023 at 02:56:04PM +0100, Oleksij Rempel wrote:
> if (data->eee_enabled) {
> + phydev->eee_enabled = true;
> if (data->advertised)
> - adv[0] = data->advertised;
> - else
> - linkmode_copy(adv, phydev->supported_eee);
> + phydev->advertising_eee[0] = data->advertised;
There is a behavioural change here that isn't mentioned in the patch
description - if data->advertised was zero, you were setting the
link modes to the full EEE supported set. After this patch, you
appear to leave advertising_eee untouched (so whatever it was.)
Which is the correct behaviour for this interface?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!