RE: [PATCH v4 2/5] drivers: regulator: Add ADI MAX77541/MAX77540 Regulator Support

[Sahin, Okan]

Wed, 1 Feb 2023 5:30 PM
Mark Brown <broonie@xxxxxxxxxx> wrote:

>On Wed, Feb 01, 2023 at 01:35:15PM +0300, Okan Sahin wrote:
>> Regulator driver for both MAX77541 and MAX77540.
>> The MAX77541 is a high-efficiency step-down converter with two 3A
>> switching phases for single-cell Li+ battery and 5VDC systems.
>
>Please submit patches using subject lines reflecting the style for the subsystem,
>this makes it easier for people to identify relevant patches.
>Look at what existing commits in the area you're changing are doing and make
>sure your subject lines visually resemble what they're doing.
>There's no need to resubmit to fix this alone.
>
>> +	if (max77541->chip->id == MAX77540)
>> +		desc = max77540_regulators_desc;
>> +	else if (max77541->chip->id == MAX77541)
>> +		desc = max77541_regulators_desc;
>> +	else
>> +		return -EINVAL;
>
>Write this as a switch statement for extensibility.
>
>Otherwise this looks good.

Hi Mark,

Thank you for your feedback.  I am not sure that I fully understand your feedback. What do you mean by "reflecting style for the subsystem". For example, this patch includes files modified or added under regulator directory as stated in the subject line. Do I need to say anything about mfd as regulator is subdevice?

Regards,
Okan Sahin