Re: [PATCH] staging: rtl8712: Fix multiple line dereference

[Philipp Hortmann]

On 2/20/23 09:40, Shibo Li wrote:
> This patch fixes the following warning in rtl871x_mlme.c
>
> WARNING: Avoid multiple line dereference - prefer 'adapter->securitypriv.PrivacyAlgrthm'
>
> Signed-off-by: Shibo Li <zzutcyha@xxxxxxx>
> ---
>   drivers/staging/rtl8712/rtl871x_mlme.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
> index 63e12b157001..cc47c1cedd4e 100644
> --- a/drivers/staging/rtl8712/rtl871x_mlme.c
> +++ b/drivers/staging/rtl8712/rtl871x_mlme.c
> @@ -773,8 +773,8 @@ void r8712_joinbss_event_callback(struct _adapter *adapter, u8 *pbuf)
>   						adapter->securitypriv.busetkipkey = false;
>   						adapter->securitypriv.bgrpkey_handshake = false;
>   						ptarget_sta->ieee8021x_blocked = true;
> -						ptarget_sta->XPrivacy = adapter->
> -						securitypriv.PrivacyAlgrthm;
> +						ptarget_sta->XPrivacy =
> +							adapter->securitypriv.PrivacyAlgrthm;
>   						memset((u8 *)&ptarget_sta->x_UncstKey,
>   							 0,
>   							 sizeof(union Keytype));

Tested-by: Philipp Hortmann <philipp.g.hortmann@xxxxxxxxx> AW-NU120