Re: [PATCH v2 2/3] ASoC: dt-bindings: sama7g5-pdmc: add microchip,startup-delay-us binding

[Claudiu.Beznea]

On 21.02.2023 00:56, Rob Herring wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Fri, Feb 17, 2023 at 02:41:50PM +0200, Claudiu Beznea wrote:
>> Add microchip,startup-delay-us binding to let PDMC users to specify
>> startup delay.
> 
> The diff tells me all this. Why does this need to be per platform?

PDMC can work with different kind of microphones, thus different boards
could have different microphones. Depending on microphone type the PDMC
would need to wait longer or shorter period than the default chosen period
to filter unwanted noise. Thus the need of having this specified though
device tree. Would you prefer to have this in commit message?

Thank you,
Claudiu

> 
>>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> ---
>>  .../devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml   | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml b/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml
>> index c4cf1e5ab84b..9b40268537cb 100644
>> --- a/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml
>> +++ b/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml
>> @@ -67,6 +67,12 @@ properties:
>>      maxItems: 4
>>      uniqueItems: true
>>
>> +  microchip,startup-delay-us:
>> +    description: |
>> +      Specifies the delay in microseconds that needs to be applied after
>> +      enabling the PDMC microphones to avoid unwanted noise due to microphones
>> +      not being ready.
>> +
>>  required:
>>    - compatible
>>    - reg
>> --
>> 2.34.1
>>