RE: [PATCH] net: phy: at803x: fix the wol setting functions

[Leo Li]

> -----Original Message-----
> From: Andrew Lunn <andrew@xxxxxxx>
> Sent: Tuesday, February 21, 2023 4:57 PM
> To: Leo Li <leoyang.li@xxxxxxx>
> Cc: Heiner Kallweit <hkallweit1@xxxxxxxxx>; Russell King
> <linux@xxxxxxxxxxxxxxx>; David S . Miller <davem@xxxxxxxxxxxxx>; Jakub
> Kicinski <kuba@xxxxxxxxxx>; Luo Jie <luoj@xxxxxxxxxxxxxx>;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Viorel Suman
> <viorel.suman@xxxxxxx>; Wei Fang <wei.fang@xxxxxxx>
> Subject: Re: [PATCH] net: phy: at803x: fix the wol setting functions
> 
> On Tue, Feb 21, 2023 at 04:40:31PM -0600, Li Yang wrote:
> > In 7beecaf7d507 ("net: phy: at803x: improve the WOL feature"), it
> > seems not correct to use a wol_en bit in a 1588 Control Register which
> > is only available on AR8031/AR8033(share the same phy_id) to determine
> > if WoL is enabled.  Change it back to use AT803X_INTR_ENABLE_WOL for
> > determining the WoL status which is applicable on all chips supporting
> > wol. Also update the at803x_set_wol() function to only update the 1588
> > register on chips having it.
> 
> > After this change, disabling wol at probe from d7cd5e06c9dd ("net:
> > phy: at803x: disable WOL at probe") is no longer needed.  So it is
> > removed.
> 
> Rather than remove it, please git revert it, and explain in the commit
> message why.

Not all changes from that patch is removed.  The remaining part might still be useful.

> 
> >
> > Also remove the set_wol()/get_wol() callbacks from AR8032 which
> > doesn't support WoL.
> 
> This change was part of 5800091a2061 ("net: phy: at803x: add support for
> AR8032 PHY")
> 
> Please break this patch up into individual fixes. The different fixes might
> need different levels of backporting etc.

Ok.  I can split this out.

Regards,
Leo