Re: [PATCH v5 2/2] trigger: ledtrig-tty: add additional modes

From: Jiri Slaby
Date: Wed Feb 22 2023 - 02:16:43 EST


On 22. 02. 23, 7:07, Florian Eckert wrote:


On 2023-02-22 01:02, kernel test robot wrote:
Hi Florian,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tty/tty-testing]
[also build test WARNING on tty/tty-next tty/tty-linus
staging/staging-testing staging/staging-next staging/staging-linus
pavel-leds/for-next linus/master v6.2 next-20230221]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:
https://github.com/intel-lab-lkp/linux/commits/Florian-Eckert/tty-new-helper-function-tty_get_mget/20230221-162126
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
tty-testing
patch link: https://lore.kernel.org/r/20230221081901.15557-3-fe%40dev.tdt.de
patch subject: [PATCH v5 2/2] trigger: ledtrig-tty: add additional modes
reproduce:
        #
https://github.com/intel-lab-lkp/linux/commit/445b7555bccd279bf106995ee42f5dbef2e97c8b
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review
Florian-Eckert/tty-new-helper-function-tty_get_mget/20230221-162126
        git checkout 445b7555bccd279bf106995ee42f5dbef2e97c8b
        make menuconfig
        # enable CONFIG_COMPILE_TEST, CONFIG_WARN_MISSING_DOCUMENTS,
CONFIG_WARN_ABI_ERRORS
        make htmldocs

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link:
https://lore.kernel.org/oe-kbuild-all/202302220740.2RKDHnof-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

Documentation/ABI/testing/sysfs-class-led-trigger-tty:9: WARNING: Unexpected indentation.
Documentation/ABI/testing/sysfs-class-led-trigger-tty:9: WARNING: Block quote ends without a blank line; unexpected unindent.

vim +9 Documentation/ABI/testing/sysfs-class-led-trigger-tty

   > 9    Date:        January 2023

I apologies for the question! But I don't know what the test buildbot here wants from me.
I've looked at the other files and I can't find anything that stands out.

sphinx is always misleading.

It's the indentation of all "LED on if ...".

--
js
suse labs