Re: [PATCH v1 04/10] ASoC: tegra: Support RT5631 by machine driver

[Svyatoslav Ryhel]

вт, 21 лют. 2023 р. о 21:32 Dan Carpenter <error27@xxxxxxxxx> пише:
>
> On Tue, Feb 21, 2023 at 08:32:05PM +0200, Svyatoslav Ryhel wrote:
> > diff --git a/sound/soc/tegra/tegra_asoc_machine.c b/sound/soc/tegra/tegra_asoc_machine.c
> > index 78faa8bcae27..607800ec07a6 100644
> > --- a/sound/soc/tegra/tegra_asoc_machine.c
> > +++ b/sound/soc/tegra/tegra_asoc_machine.c
> > @@ -51,6 +51,17 @@ static struct snd_soc_jack_gpio tegra_machine_headset_jack_gpio = {
> >  };
> >
> >  /* Mic Jack */
>
> This comment doesn't make sense now.  It was never super useful, though.
> Just delete it.

It does. Headset is Mic Jack + Headphones combined. headset_check function
performs check for a Mic Jack component in plugged Jack 3.5

> > +static int headset_check(void *data)
> > +{
> > +     struct tegra_machine *machine = (struct tegra_machine *)data;
> > +
> > +     /* Detect mic insertion only if 3.5 jack is in */
> > +     if (gpiod_get_value_cansleep(machine->gpiod_hp_det) &&
> > +         gpiod_get_value_cansleep(machine->gpiod_mic_det))
> > +             return SND_JACK_MICROPHONE;
> > +
> > +     return 0;
> > +}
> >
> >  static struct snd_soc_jack tegra_machine_mic_jack;
> >
> > @@ -183,8 +194,15 @@ int tegra_asoc_machine_init(struct snd_soc_pcm_runtime *rtd)
>
> regards,
> dan carpenter