Re: [PATCH v2 00/10] Panfrost: Improve and add MediaTek SoCs support

[Chen-Yu Tsai]

On Wed, Feb 22, 2023 at 3:55 PM Chen-Yu Tsai <wenst@xxxxxxxxxxxx> wrote:
>
> On Tue, Feb 21, 2023 at 04:37:30PM +0100, AngeloGioacchino Del Regno wrote:
> > Changes in v2:
> >  - Add power-domain-names commit from Chen-Yu to the series
> >  - Kept sram-supply in base schema, overridden for non-MediaTek
> >  - Added Reviewed-by tags from Steven Price to the driver commits
> >    (as released in reply to v1's cover letter - thanks!)
> >
> > This series adds support for new MediaTek SoCs (MT8186/MT8192/MT8195)
> > and improves MT8183 support: since the mtk-regulator-coupler driver
> > was picked, it is now useless for Panfrost to look for, and manage,
> > two regulators (GPU Vcore and GPU SRAM) on MediaTek;
> >
> > The aforementioned driver will take care of keeping the voltage
> > relation (/constraints) of the two regulators on its own when a
> > voltage change request is sent to the Vcore, solving the old time
> > issue with not working DVFS on Panfrost+MediaTek (due to devfreq
> > supporting only single regulator).
> >
> > In the specific case of MT8183, in order to not break the ABI, it
> > was necessary to add a new compatible for enabling DVFS.
> >
> > Alyssa Rosenzweig (3):
> >   drm/panfrost: Increase MAX_PM_DOMAINS to 5
> >   drm/panfrost: Add the MT8192 GPU ID
> >   drm/panfrost: Add mediatek,mt8192-mali compatible
> >
> > AngeloGioacchino Del Regno (6):
> >   dt-bindings: gpu: mali-bifrost: Split out MediaTek power-domains
> >     variation
> >   dt-bindings: gpu: mali-bifrost: Allow up to 5 power domains for MT8192
> >   dt-bindings: gpu: mali-bifrost: Add compatible for MT8195 SoC
> >   dt-bindings: gpu: mali-bifrost: Add new MT8183 compatible
> >   dt-bindings: gpu: mali-bifrost: Add a compatible for MediaTek MT8186
> >   drm/panfrost: Add new compatible for Mali on the MT8183 SoC
> >
> > Chen-Yu Tsai (1):
> >   dt-bindings: gpu: mali-bifrost: Add power-domain-names to base schema
> >
> >  .../bindings/gpu/arm,mali-bifrost.yaml        | 67 ++++++++++++++++++-
> >  drivers/gpu/drm/panfrost/panfrost_device.h    |  2 +-
> >  drivers/gpu/drm/panfrost/panfrost_drv.c       | 28 ++++++++
> >  drivers/gpu/drm/panfrost/panfrost_gpu.c       |  8 +++
> >  4 files changed, 101 insertions(+), 4 deletions(-)
>
> Tested-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>
>
> on MT8183, MT8186, MT8192, MT8195 with glmark2.

Note: the MT8186 was tested with incorrect bindings with one extra power
domain, but that doesn't affect functionality.