Re: [PATCH -next] net/mlx5: Remove NULL check before dev_{put, hold}
From: Leon Romanovsky
Date: Wed Feb 22 2023 - 04:38:41 EST
On Wed, Feb 22, 2023 at 10:29:44AM +0800, Yang Li wrote:
> The call netdev_{put, hold} of dev_{put, hold} will check NULL,
> so there is no need to check before using dev_{put, hold},
> remove it to silence the warning:
>
> ./drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c:714:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed.
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4174
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Please submit this patch with fixed title from -next to be net-next
after merge window.
Thanks