Re: [PATCH] tools/memory-model: Add details about SRCU read-side critical sections
From: Alan Stern
Date: Wed Feb 22 2023 - 15:32:17 EST
On Wed, Feb 22, 2023 at 11:50:51AM -0800, Paul E. McKenney wrote:
> On Mon, Feb 20, 2023 at 04:06:13PM -0500, Alan Stern wrote:
> > On Sun, Feb 19, 2023 at 12:13:14PM -0500, Joel Fernandes wrote:
> > > On Sun, Feb 19, 2023 at 12:11 PM Joel Fernandes <joel@xxxxxxxxxxxxxxxxx> wrote:
> > > > Even though it may be redundant: would it be possible to also mention
> > > > (after this paragraph) that this case forms an undesirable "->rf" link
> > > > between B and C, which then causes us to link A and D as a result?
> > > >
> > > > A[srcu-lock] ->data B[once] ->rf C[once] ->data D[srcu-unlock].
> > >
> > > Apologies, I meant here, care must be taken to avoid:
> > >
> > > A[srcu-lock] ->data B[srcu-unlock] ->rf C[srcu-lock] ->data D[srcu-unlock].
> >
> > Revised patch below. I changed more than just this bit. Mostly small
> > edits to improve readability, but I did add a little additional
> > material.
>
> Looks good to me, thank you!
>
> Would you like to send a formal patch, or are you thinking in terms
> of making other changes first?
I'll send a formal patch when I find time to write an appropriate
Changelog description.
I also have in mind making other changes along the lines Joel suggested,
but they will be separate patches.
Alan