Re: [PATCH bpf-next] bpf: Add bpf_cgroup_from_id() kfunc
From: Alexei Starovoitov
Date: Wed Feb 22 2023 - 16:20:38 EST
On Tue, Feb 21, 2023 at 2:09 PM Tejun Heo <tj@xxxxxxxxxx> wrote:
>
> cgroup ID is an userspace-visible 64bit value uniquely identifying a given
> cgroup. As the IDs are used widely, it's useful to be able to look up the
> matching cgroups. Add bpf_cgroup_from_id().
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> ---
> Documentation/bpf/kfuncs.rst | 10 +++--
> kernel/bpf/helpers.c | 18 ++++++++
> .../selftests/bpf/prog_tests/cgrp_kfunc.c | 1 +
> .../selftests/bpf/progs/cgrp_kfunc_common.h | 1 +
> .../selftests/bpf/progs/cgrp_kfunc_success.c | 42 +++++++++++++++++++
> 5 files changed, 69 insertions(+), 3 deletions(-)
Looks great, but could you please split it into two patches:
One for helpers.c and kfuncs.rst and another for selftests
with [PATCH bpf-next] selftests/bpf: subject ?
Doesn't matter much in this case, but it might ease backporting
and easier to track patches grouped by subj.