Re: [PATCH v4 1/4] locktorture: Add nested_[un]lock() hooks and nlocks parameter

[John Stultz]

On Wed, Feb 22, 2023 at 11:07 AM Paul E. McKenney <paulmck@xxxxxxxxxx> wrote:
> On Tue, Feb 21, 2023 at 07:02:35PM +0000, John Stultz wrote:
> > In order to extend locktorture to support lock nesting, add
> > nested_lock() and nested_unlock() hooks to the torture ops.
> >
> > These take a 32bit lockset mask which is generated at random,
> > so some number of locks will be taken before the main lock is
> > taken and released afterwards.
> >
> > Additionally, add nested_locks module parameter to allow
> > specifying the number of nested locks to be used.
> >
> > This has been helpful to uncover issues in the proxy-exec
> > series development.
> >
> > This was inspired by locktorture extensions originally implemented
> > by Connor O'Brien, for stress testing the proxy-execution series:
> >   https://lore.kernel.org/lkml/20221003214501.2050087-12-connoro@xxxxxxxxxx/
> >
> > Cc: Davidlohr Bueso <dave@xxxxxxxxxxxx>
> > Cc: "Paul E. McKenney" <paulmck@xxxxxxxxxx>
> > Cc: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
> > Cc: Joel Fernandes <joel@xxxxxxxxxxxxxxxxx>
> > Cc: Juri Lelli <juri.lelli@xxxxxxxxxx>
> > Cc: Valentin Schneider <vschneid@xxxxxxxxxx>
> > Cc: Dietmar Eggemann <dietmar.eggemann@xxxxxxx>
> > Cc: kernel-team@xxxxxxxxxxx
> > Reviewed-by: Davidlohr Bueso <dave@xxxxxxxxxxxx>
> > Co-developed-by: Connor O'Brien <connoro@xxxxxxxxxx>
> > Signed-off-by: Connor O'Brien <connoro@xxxxxxxxxx>
> > Signed-off-by: John Stultz <jstultz@xxxxxxxxxx>
>
> I queued this series in place of its precedessor, thank you for the
> update!
>
> Given what I know now, I will set this up for the v6.4 merge window.

Much appreciated! Apologies for the churn, I wasn't sure if you caught
the last iteration or not, so I figured I'd send it out again.

thanks
-john