RE: [PATCH] Revert "venus: firmware: Correct non-pix start and end addresses"

[Vikash Garodia]

Hi All,

>-----Original Message-----
>From: Thorsten Leemhuis <regressions@xxxxxxxxxxxxx>
>Sent: Tuesday, February 21, 2023 8:33 PM
>To: Vikash Garodia <vgarodia@xxxxxxxxxxxxxxxx>
>Cc: linux-kernel@xxxxxxxxxxxxxxx; mka@xxxxxxxxxxxx; Albert Esteve
><aesteve@xxxxxxxxxx>; stanimir.varbanov@xxxxxxxxxx; Enric Balletbo i Serra
><eballetb@xxxxxxxxxx>; Andy Gross <agross@xxxxxxxxxx>; Bjorn Andersson
><andersson@xxxxxxxxxx>; Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>; Stanimir
>Varbanov <stanimir.k.varbanov@xxxxxxxxx>; Vikash Garodia (QUIC)
><quic_vgarodia@xxxxxxxxxxx>; linux-arm-msm@xxxxxxxxxxxxxxx; linux-
>media@xxxxxxxxxxxxxxx; Fritz Koenig <frkoenig@xxxxxxxxxx>; Dikshita Agarwal
>(QUIC) <quic_dikshita@xxxxxxxxxxx>; Rajeshwar Kurapaty (QUIC)
><quic_rkurapat@xxxxxxxxxxx>; Javier Martinez Canillas <javierm@xxxxxxxxxx>;
>Linux regressions mailing list <regressions@xxxxxxxxxxxxxxx>; Mauro Carvalho
>Chehab <mchehab@xxxxxxxxxx>
>Subject: Re: [PATCH] Revert "venus: firmware: Correct non-pix start and end
>addresses"
>
>WARNING: This email originated from outside of Qualcomm. Please be wary of
>any links or attachments, and do not enable macros.
>
>On 15.02.23 14:18, Linux regression tracking (Thorsten Leemhuis) wrote:
>> On 15.02.23 11:57, Javier Martinez Canillas wrote:
>>> On Wed, Feb 15, 2023 at 11:53 AM Linux regression tracking (Thorsten
>>> Leemhuis) <regressions@xxxxxxxxxxxxx> wrote:
>>>> On 11.02.23 15:27, Linux regression tracking (Thorsten Leemhuis) wrote:
>>>>> On 10.02.23 11:07, Javier Martinez Canillas wrote:
>>>>>> On 2/10/23 10:22, Vikash Garodia wrote:
>>>>>>
>>>>>>>> So what should we do about this folks? Since not allowing the
>>>>>>>> driver to probe on at least SC7180 is a quite serious
>>>>>>>> regression, can we revert for now until a proper fix is figured out?
>>>>>>> I am able to repro this issue on sc7180 and discussing with
>>>>>>> firmware team on the cause of reset failure. The original patch
>>>>>>> was raised for fixing rare SMMU faults during warm boot of video
>>>>>>> hardware. Hence looking to understand the regressing part before we
>proceed to revert.
>>>>>> Great, if you are working on a proper fix then that would be much better
>indeed.
>>>>> Yeah, that's great, but OTOH: there is almost certainly just one
>>>>> week before 6.2 will be released. Ideally this should be fixed by then.
>>>>> Vikash, do you think that's in the cards? If not: why not revert
>>>>> this now to make sure 6.2 works fine?
>>>> Hmm, no reply. And we meanwhile have Wednesday and 6.2 is almost
>>>> certainly going to be out on Sunday. And the problem was called "a
>>>> quite serious regression" above. So why not quickly fix this with
>>>> the revert, as proposed earlier?
>>>> Vikash? Javier?
>>>
>>> I agree with you, that we should land this revert and then properly
>>> fix the page fault issue in v6.3.
>>>
>>> But it's not my call, the v4l2/media folks have to decide that.
>>
>> In that case: Mauro, what's your opinion here?
>>
>> Thread starts here:
>> https://lore.kernel.org/lkml/20230207102254.1446461-1-javierm@redhat.c
>> om/
>>
>> Regression report:
>> https://lore.kernel.org/lkml/Y9LSMap%2BjRxbtpC8@xxxxxxxxxx/
>
>No reply from Mauro and Linus chose to not apply the revert I pointed him to.
>That at this point leads to the question:
>
>Vikash, did you or somebody else make any progress to fix this properly?

We tried with different settings for the registers and arrive at a conclusion that
the original configuration was proper. There is no need to explicitly configure
the secure non-pixel region when there is no support for the usecase. So, in summary,
we are good to have the revert.

Stan, could you please help with the revert and a pull request having this revert
alongwith other pending changes ?

>Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>--
>Everything you wanna know about Linux kernel regression tracking:
>https://linux-regtracking.leemhuis.info/about/#tldr
>If I did something stupid, please tell me, as explained on that page.
>
>#regzbot poke