Re: [RFC PATCH 1/6] dt-bindings: iio: light: Support ROHM BU27034

[Vaittinen, Matti]

Hi dee Ho Krzysztof,

Thanks for the review! It's nice you had the time to take a look on RFC :)

On 2/22/23 20:57, Krzysztof Kozlowski wrote:
> On 22/02/2023 17:14, Matti Vaittinen wrote:
>> ROHM BU27034 is an ambient light sesnor with 3 channels and 3 photo diodes
>> capable of detecting a very wide range of illuminance. Typical application
>> is adjusting LCD and backlight power of TVs and mobile phones.
>>
>> Add initial dt-bindings.
> 
> Driver can be "initial", but bindings better to be closer to complete,
> even if not used by the driver currently.

Out of the curiosity - why is that? (Please, don't take me wrong, I am 
not trying to argue against this - just learn the reason behind). I 
can't immediately see the harm caused by adding new properties later 
when we learn more of hardware. (and no, I don't expect this simple IC 
to gain at least many properties).

>> Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
>> ---
>>   .../bindings/iio/light/rohm-bu27034.yaml      | 46 +++++++++++++++++++
>>   1 file changed, 46 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/iio/light/rohm-bu27034.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/iio/light/rohm-bu27034.yaml b/Documentation/devicetree/bindings/iio/light/rohm-bu27034.yaml
>> new file mode 100644
>> index 000000000000..a3a642c259e8
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/light/rohm-bu27034.yaml
> 
> 
> Comma as a separator, so:
> rohm,bu27034.yaml

Oh, yes. So it seems.

Strange, I could have sworn I used hyphen in binding file names 
previously although the comma has been used in the compatible. I had to 
go back in time (lore,kernel.org) to check my earlier submissions. Well, 
my mind seems to be playing tricks on me @_@. I'll fix this before 
sending out non RFC series :)

Good catch (as always)! Thanks!

>> @@ -0,0 +1,46 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/iio/light/rohm-bu27034.yaml#
> 
> With filename and $id fix:
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> 
> 
> Best regards,
> Krzysztof
> 

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~