Re: [PATCH 00/13] Rename k[v]free_rcu() single argument to k[v]free_rcu_mightsleep()
From: Paul E. McKenney
Date: Thu Feb 23 2023 - 12:14:53 EST
On Thu, Feb 23, 2023 at 06:21:46PM +0200, Julian Anastasov wrote:
>
> Hello,
>
> On Thu, 23 Feb 2023, Paul E. McKenney wrote:
>
> > > > Not sure if you guys noticed but on latest rcu/dev:
> > > >
> > > > net/netfilter/ipvs/ip_vs_est.c: In function ‘ip_vs_stop_estimator’:
> > > > net/netfilter/ipvs/ip_vs_est.c:552:15: error: macro "kfree_rcu" requires 2
> > > > arguments, but only 1 given
> > > > kfree_rcu(td);
> > > > ^
> > > > net/netfilter/ipvs/ip_vs_est.c:552:3: error: ‘kfree_rcu’ undeclared (first use in
> > > > this function); did you mean ‘kfree_skb’?
> > > > kfree_rcu(td);
> > > > ^~~~~~~~~
> > > > kfree_skb
> > > > net/netfilter/ipvs/ip_vs_est.c:552:3: note: each undeclared identifier is
> > > > reported only once for each function it appears in
> > >
> > > Hi Frederic Weisbecker,
> > >
> > > I encountered the same build error as yours.
> > > Per the discussion link below, the fix for this build error by Uladzislau Rezki will be picked up by some other maintainer's branch?
> > > @Paul E . McKenney, please correct me if my understanding is wrong. 😊
> > >
> > > https://lore.kernel.org/rcu/Y9qc+lgR1CgdszKs@salvia/
> >
> > Pablo and Julian, how are things coming with that patch?
>
> Fix is already in net and net-next tree
Very good, thank you! Is this going into this merge window or is it
expected to wait for v6.4?
Thanx, Paul