Re: [PATCH v2] KVM: SVM: hyper-v: placate modpost section mismatch error
From: Zhi Wang
Date: Thu Feb 23 2023 - 16:11:54 EST
On Wed, 22 Feb 2023 19:32:53 +0100
Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
Maybe we can use __always_inline? I just noticed this thread today by chance.
https://lore.kernel.org/all/20210624095147.880513802@xxxxxxxxxxxxx/
> On 2/22/23 17:46, Sean Christopherson wrote:
> > Tag svm_hv_hardware_setup() with __init to fix a modpost warning as the
> > non-stub implementation accesses __initdata (svm_x86_ops), i.e. would
> > generate a use-after-free if svm_hv_hardware_setup() were actually invoked
> > post-init. The helper is only called from svm_hardware_setup(), which is
> > also __init, i.e. other than the modpost warning, lack of __init is benign.
>
> Done. It's caused by the compiler deciding not to inline the function,
> probably.
>
> Also Cc'ed stable.
>
> Paolo
>