Re: [PATCH v2 01/29] LoongArch: KVM: Add kvm related header files

[Tianrui Zhao]

在 2023年02月21日 12:36, Xi Ruoyao 写道:
> On Mon, 2023-02-20 at 14:57 +0800, Tianrui Zhao wrote:
>
> /* snip */
>
> > +/*
> > + * for KVM_GET_FPU and KVM_SET_FPU
> > + */
> > +struct kvm_fpu {
> > +	__u32 fcsr;
> > +	__u32 none;
> > +	__u64 fcc;    /* 8x8 */
> > +	struct kvm_fpureg {
> > +		__u64 val64[4];	//support max 256 bits
> > +	} fpr[32];
> Do we need __attribute__((__aligned__(16))) for fpureg (like
> sc_extcontext in struct sigcontext)?

Thanks,  the loongarch_fpu variable is already has FPU_ALIGN feature in 
the kvm_vcpu_arch structure, so it need not to use __aligned__(16).

Thanks
Tianrui Zhao

> > +};
> > +
> > +/*
> > + * For LOONGARCH, we use KVM_SET_ONE_REG and KVM_GET_ONE_REG to
>            ^^^^^^^^^
>            LoongArch

Thanks, I will fix it

Thanks
Tianrui Zhao

> > access various
> > + * registers.  The id field is broken down as follows:
> > + *
> > + *  bits[63..52] - As per linux/kvm.h
> > + *  bits[51..32] - Must be zero.
> > + *  bits[31..16] - Register set.