Re: [RFC PATCH 2/2] drm/msm/dsi: use new dpu_dsc_populate_dsc_config()

[Abhinav Kumar]

On 2/24/2023 1:14 PM, Dmitry Baryshkov wrote:
> On 24/02/2023 23:09, Abhinav Kumar wrote:
> > On 2/24/2023 1:04 PM, Dmitry Baryshkov wrote:
> > > On 24/02/2023 21:40, Kuogee Hsieh wrote:
> > > > use new introduced dpu_dsc_populate_dsc_config() to calculate
> > > > and populate drm_dsc_info instead of hard code value.
> > >
> > > DPU is an optional component, so DSI driver should not depend on the 
> > > DPU driver.
> >
> > Today, the implicit dependency is already there. Without the DPU DSC 
> > blocks, the DSI cannot operate in compressed mode.
>
> It can not operate, but one will compile w/o other driver.

Ack.

> > But, from a SW standpoint I agree we can separate this.
> >
> > We can move this one level up to the disp/ or msm/ folder
> >
> > What do you think about that?
>
> I think about drivers/gpu/drm/display/drm_dsc_helper.c

No, that wont work because of the explanation given in the prev patch.

> > --
> With best wishes
> Dmitry