On 27/02/2023 17.04, Thomas Zimmermann wrote:
Hi
Am 27.02.23 um 08:55 schrieb Asahi Lina:
On 27/02/2023 16.45, Thomas Zimmermann wrote:
Hi
Am 25.02.23 um 22:51 schrieb Dmitry Osipenko:
On 2/5/23 15:51, Asahi Lina wrote:
-EXPORT_SYMBOL_GPL(drm_gem_shmem_get_pages_sgt);
+EXPORT_SYMBOL(drm_gem_shmem_get_pages_sgt);
Note it was a GPL symbol. I expect that all drm-shmem exports should be GPL.
Right. I didn't notice that change, but it's probably not allowed. This
needs to be reverted to a GPL export
I'm sorry, this was not intentional! I think I removed and re-added the
export as part of making the wrapper and didn't notice it used to be _GPL...
Do you want me to send a patch to add it back?
Yes, please do. The Fixes tag is
Fixes: ddddedaa0db9 ("drm/shmem-helper: Fix locking for
drm_gem_shmem_get_pages_sgt()")
This commit is in drm-misc-next-fixes. But the branch is closed already
as we're in the middle of the merge window. I think it's best to merge
the fix through drm-misc-fixes after the -rc1 hs been tagged.
Sent! I also noticed that there are quite a few other non-GPL exports in
the file, with no real logic that I can see... I'm guessing most of
those weren't intentional either?
~~ Lina
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature