Re: [PATCH v8 01/16] dma-buf/dma-fence: Add deadline awareness
From: Bagas Sanjaya
Date: Wed Mar 01 2023 - 03:28:19 EST
On 3/1/23 05:58, Rob Clark wrote:
> From: Rob Clark <robdclark@xxxxxxxxxxxx>
>
> Add a way to hint to the fence signaler of an upcoming deadline, such as
> vblank, which the fence waiter would prefer not to miss. This is to aid
> the fence signaler in making power management decisions, like boosting
> frequency as the deadline approaches and awareness of missing deadlines
> so that can be factored in to the frequency scaling.
>
> v2: Drop dma_fence::deadline and related logic to filter duplicate
> deadlines, to avoid increasing dma_fence size. The fence-context
> implementation will need similar logic to track deadlines of all
> the fences on the same timeline. [ckoenig]
> v3: Clarify locking wrt. set_deadline callback
> v4: Clarify in docs comment that this is a hint
> v5: Drop DMA_FENCE_FLAG_HAS_DEADLINE_BIT.
> v6: More docs
> v7: Fix typo, clarify past deadlines
>
> Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx>
> Reviewed-by: Christian König <christian.koenig@xxxxxxx>
> Acked-by: Pekka Paalanen <pekka.paalanen@xxxxxxxxxxxxx>
I have given my Reviewed-by from v7 [1], but it didn't get picked up,
thus giving it again:
Reviewed-by: Bagas Sanjaya <bagasdotme@xxxxxxxxx>
Thanks.
[1]: https://lore.kernel.org/linux-doc/Y%2F7LfLxhIjDpD4D3@xxxxxxxxx/
--
An old man doll... just what I always wanted! - Clara