Re: [Patch V6 3/3] spi: tegra210-quad: Enable TPM wait polling

[Jon Hunter]

On 27/02/2023 17:21, Krishna Yarlagadda wrote:
> Trusted Platform Module requires flow control. As defined in TPM
> interface specification, client would drive MISO line at same cycle as
> last address bit on MOSI.
> Tegra241 QSPI controller has TPM wait state detection feature which is
> enabled for TPM client devices reported in SPI device mode bits.

Earlier in patch 2/3 we say Tegra234 and Tegra241 but here we just say 
Tegra241.

>   static struct tegra_qspi_soc_data tegra186_qspi_soc_data = {
>   	.has_dma = true,
>   	.cmb_xfer_capable = true,
> +	.support_tpm = false,
>   	.cs_count = 1,
>   };
>   
>   static struct tegra_qspi_soc_data tegra234_qspi_soc_data = {
>   	.has_dma = false,
>   	.cmb_xfer_capable = true,
> +	.support_tpm = true,
>   	.cs_count = 1,
>   };
>   
>   static struct tegra_qspi_soc_data tegra241_qspi_soc_data = {
>   	.has_dma = false,
>   	.cmb_xfer_capable = true,
> +	.support_tpm = true,
>   	.cs_count = 4,
>   };
>   

We enable for both Tegra234 and Tegra241 and so the commit message 
should say so.

Jon

--
nvpublic