Re: [PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it

From: Lee Jones
Date: Wed Mar 01 2023 - 09:22:33 EST


On Sat, 25 Feb 2023, Randy Dunlap wrote:

> REGMAP is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
>
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
>
> Therefore, change the use of "depends on REGMAP" to "select REGMAP".
>
> Fixes: 3fce8e1eb994 ("leds: TI LMU: Add common code for TI LMU devices")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Dan Murphy <dmurphy@xxxxxx>
> Cc: Pavel Machek <pavel@xxxxxx>
> Cc: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>
> Cc: Lee Jones <lee@xxxxxxxxxx>
> Cc: linux-leds@xxxxxxxxxxxxxxx
> ---
> drivers/leds/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

--
Lee Jones [李琼斯]