Re: [PATCH v2 0/3] wifi: rtw88: USB fixes

From: Greg KH
Date: Wed Mar 01 2023 - 10:22:28 EST


On Wed, Mar 01, 2023 at 08:11:41AM +0100, Sascha Hauer wrote:
> On Fri, Feb 10, 2023 at 12:16:29PM +0100, Sascha Hauer wrote:
> > This series addresses issues for the recently added RTW88 USB support
> > reported by Andreas Henriksson and also our customer.
> >
> > The hardware can't handle urbs that have a size of multiple of the
> > bulkout_size (usually 512 bytes). The symptom is that the hardware
> > stalls completely. The issue can be reproduced by sending a suitably
> > sized ping packet from the device:
> >
> > ping -s 394 <somehost>
> >
> > (It's 394 bytes here on a RTL8822CU and RTL8821CU, the actual size may
> > differ on other chips, it was 402 bytes on a RTL8723DU)
> >
> > Other than that qsel was not set correctly. The sympton here is that
> > only one of multiple bulk endpoints was used to send data.
> >
> > Changes since v1:
> > - Use URB_ZERO_PACKET to let the USB host controller handle it automatically
> > rather than working around the issue.
> >
> > Sascha Hauer (3):
> > wifi: rtw88: usb: Set qsel correctly
> > wifi: rtw88: usb: send Zero length packets if necessary
> > wifi: rtw88: usb: drop now unnecessary URB size check
>
> These patches went in upstream as:
>
> 7869b834fb07c wifi: rtw88: usb: Set qsel correctly
> 07ce9fa6ab0e5 wifi: rtw88: usb: send Zero length packets if necessary
> 462c8db6a0116 wifi: rtw88: usb: drop now unnecessary URB size check
>
> These patches make the RTW88 USB support much more reliable. Can they be
> picked for the current 6.2 stable series please?

All now queued up, thanks.

greg k-h