Re: [PATCH v7 08/41] x86/shstk: Add user control-protection fault handler

From: Borislav Petkov
Date: Wed Mar 01 2023 - 13:06:27 EST


On Mon, Feb 27, 2023 at 02:29:24PM -0800, Rick Edgecombe wrote:
> diff --git a/arch/x86/kernel/cet.c b/arch/x86/kernel/cet.c
> index 7ad22b705b64..cc10d8be9d74 100644
> --- a/arch/x86/kernel/cet.c
> +++ b/arch/x86/kernel/cet.c
> @@ -4,10 +4,6 @@
> #include <asm/bugs.h>
> #include <asm/traps.h>
>
> -static __ro_after_init bool ibt_fatal = true;
> -
> -extern void ibt_selftest_ip(void); /* code label defined in asm below */
> -
> enum cp_error_code {
> CP_EC = (1 << 15) - 1,

>From a previous review:

"That looks like a mask, so

CP_EC_MASK

I guess."

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette