Re: [PATCH 7/8] thermal: intel: BXT_PMIC: select REGMAP instead of depending on it

[Rafael J. Wysocki]

On Sun, Feb 26, 2023 at 6:40 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> REGMAP is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
>
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
>
> Therefore, change the use of "depends on REGMAP" to "select REGMAP".
>
> Fixes: b474303ffd57 ("thermal: add Intel BXT WhiskeyCove PMIC thermal driver")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Yegnesh S Iyer <yegnesh.s.iyer@xxxxxxxxx>
> Cc: Bin Gao <bin.gao@xxxxxxxxx>
> Cc: Zhang Rui <rui.zhang@xxxxxxxxx>
> Cc: Rafael J. Wysocki <rafael@xxxxxxxxxx>
> Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> Cc: Amit Kucheria <amitk@xxxxxxxxxx>
> Cc: linux-pm@xxxxxxxxxxxxxxx
> ---
>  drivers/thermal/intel/Kconfig |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff -- a/drivers/thermal/intel/Kconfig b/drivers/thermal/intel/Kconfig
> --- a/drivers/thermal/intel/Kconfig
> +++ b/drivers/thermal/intel/Kconfig
> @@ -73,7 +73,8 @@ endmenu
>
>  config INTEL_BXT_PMIC_THERMAL
>         tristate "Intel Broxton PMIC thermal driver"
> -       depends on X86 && INTEL_SOC_PMIC_BXTWC && REGMAP
> +       depends on X86 && INTEL_SOC_PMIC_BXTWC
> +       select REGMAP
>         help
>           Select this driver for Intel Broxton PMIC with ADC channels monitoring
>           system temperature measurements and alerts.

Applied as 6.3-rc material, thanks!