Re: [PATCH 2/2] mfd: max597x: Add support for MAX5970 and MAX5978
From: kernel test robot
Date: Wed Mar 01 2023 - 15:10:53 EST
Hi Naresh,
I love your patch! Yet something to improve:
[auto build test ERROR on 59c54c59974649b2e7bc92faae4a21e2b2408db2]
url: https://github.com/intel-lab-lkp/linux/commits/Naresh-Solanki/mfd-max597x-Add-support-for-MAX5970-and-MAX5978/20230301-171527
base: 59c54c59974649b2e7bc92faae4a21e2b2408db2
patch link: https://lore.kernel.org/r/20230301091234.3159953-2-Naresh.Solanki%409elements.com
patch subject: [PATCH 2/2] mfd: max597x: Add support for MAX5970 and MAX5978
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20230302/202303020344.8ATqgdUl-lkp@xxxxxxxxx/config)
compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/68623f7868d887a57422ce2cd6f5dc1ee1510f1e
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Naresh-Solanki/mfd-max597x-Add-support-for-MAX5970-and-MAX5978/20230301-171527
git checkout 68623f7868d887a57422ce2cd6f5dc1ee1510f1e
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202303020344.8ATqgdUl-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
drivers/regulator/max597x-regulator.c: In function 'max597x_regulator_probe':
>> drivers/regulator/max597x-regulator.c:447:41: error: 'struct max597x_data' has no member named 'dev'
447 | devm_kzalloc(max597x->dev, sizeof(struct max597x_regulator),
| ^~
>> drivers/regulator/max597x-regulator.c:453:39: error: 'struct max597x_data' has no member named 'regmap'
453 | data->regmap = max597x->regmap;
| ^~
drivers/regulator/max597x-regulator.c:462:37: error: 'struct max597x_data' has no member named 'dev'
462 | config.dev = max597x->dev;
| ^~
drivers/regulator/max597x-regulator.c:465:55: error: 'struct max597x_data' has no member named 'dev'
465 | rdev = devm_regulator_register(max597x->dev,
| ^~
In file included from include/linux/device.h:15,
from drivers/regulator/max597x-regulator.c:11:
drivers/regulator/max597x-regulator.c:468:40: error: 'struct max597x_data' has no member named 'dev'
468 | dev_err(max597x->dev, "failed to register regulator %s\n",
| ^~
include/linux/dev_printk.h:110:25: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
drivers/regulator/max597x-regulator.c:468:25: note: in expansion of macro 'dev_err'
468 | dev_err(max597x->dev, "failed to register regulator %s\n",
| ^~~~~~~
>> drivers/regulator/max597x-regulator.c:476:20: error: 'struct max597x_data' has no member named 'irq'
476 | if (max597x->irq) {
| ^~
drivers/regulator/max597x-regulator.c:478:46: error: 'struct max597x_data' has no member named 'dev'
478 | max597x_setup_irq(max597x->dev, max597x->irq, rdevs, num_switches,
| ^~
drivers/regulator/max597x-regulator.c:478:60: error: 'struct max597x_data' has no member named 'irq'
478 | max597x_setup_irq(max597x->dev, max597x->irq, rdevs, num_switches,
| ^~
drivers/regulator/max597x-regulator.c:481:40: error: 'struct max597x_data' has no member named 'dev'
481 | dev_err(max597x->dev, "IRQ setup failed");
| ^~
include/linux/dev_printk.h:110:25: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
drivers/regulator/max597x-regulator.c:481:25: note: in expansion of macro 'dev_err'
481 | dev_err(max597x->dev, "IRQ setup failed");
| ^~~~~~~
drivers/regulator/max597x-regulator.c: At top level:
drivers/regulator/max597x-regulator.c:360:35: warning: 'max597x_regmap_config' defined but not used [-Wunused-const-variable=]
360 | static const struct regmap_config max597x_regmap_config = {
| ^~~~~~~~~~~~~~~~~~~~~
vim +447 drivers/regulator/max597x-regulator.c
38493f008deb435 Patrick Rudolph 2022-07-05 434
38493f008deb435 Patrick Rudolph 2022-07-05 435
38493f008deb435 Patrick Rudolph 2022-07-05 436 struct max597x_data *max597x = dev_get_drvdata(pdev->dev.parent);
38493f008deb435 Patrick Rudolph 2022-07-05 437 struct max597x_regulator *data;
38493f008deb435 Patrick Rudolph 2022-07-05 438
38493f008deb435 Patrick Rudolph 2022-07-05 439 struct regulator_config config = { };
38493f008deb435 Patrick Rudolph 2022-07-05 440 struct regulator_dev *rdev;
38493f008deb435 Patrick Rudolph 2022-07-05 441 struct regulator_dev *rdevs[MAX5970_NUM_SWITCHES];
38493f008deb435 Patrick Rudolph 2022-07-05 442 int num_switches = max597x->num_switches;
38493f008deb435 Patrick Rudolph 2022-07-05 443 int ret, i;
38493f008deb435 Patrick Rudolph 2022-07-05 444
38493f008deb435 Patrick Rudolph 2022-07-05 445 for (i = 0; i < num_switches; i++) {
38493f008deb435 Patrick Rudolph 2022-07-05 446 data =
38493f008deb435 Patrick Rudolph 2022-07-05 @447 devm_kzalloc(max597x->dev, sizeof(struct max597x_regulator),
38493f008deb435 Patrick Rudolph 2022-07-05 448 GFP_KERNEL);
38493f008deb435 Patrick Rudolph 2022-07-05 449 if (!data)
38493f008deb435 Patrick Rudolph 2022-07-05 450 return -ENOMEM;
38493f008deb435 Patrick Rudolph 2022-07-05 451
38493f008deb435 Patrick Rudolph 2022-07-05 452 data->num_switches = num_switches;
38493f008deb435 Patrick Rudolph 2022-07-05 @453 data->regmap = max597x->regmap;
38493f008deb435 Patrick Rudolph 2022-07-05 454
38493f008deb435 Patrick Rudolph 2022-07-05 455 ret = max597x_adc_range(data->regmap, i, &max597x->irng[i], &max597x->mon_rng[i]);
38493f008deb435 Patrick Rudolph 2022-07-05 456 if (ret < 0)
38493f008deb435 Patrick Rudolph 2022-07-05 457 return ret;
38493f008deb435 Patrick Rudolph 2022-07-05 458
38493f008deb435 Patrick Rudolph 2022-07-05 459 data->irng = max597x->irng[i];
38493f008deb435 Patrick Rudolph 2022-07-05 460 data->mon_rng = max597x->mon_rng[i];
38493f008deb435 Patrick Rudolph 2022-07-05 461
38493f008deb435 Patrick Rudolph 2022-07-05 462 config.dev = max597x->dev;
38493f008deb435 Patrick Rudolph 2022-07-05 463 config.driver_data = (void *)data;
38493f008deb435 Patrick Rudolph 2022-07-05 464 config.regmap = data->regmap;
38493f008deb435 Patrick Rudolph 2022-07-05 465 rdev = devm_regulator_register(max597x->dev,
38493f008deb435 Patrick Rudolph 2022-07-05 466 ®ulators[i], &config);
38493f008deb435 Patrick Rudolph 2022-07-05 467 if (IS_ERR(rdev)) {
38493f008deb435 Patrick Rudolph 2022-07-05 468 dev_err(max597x->dev, "failed to register regulator %s\n",
38493f008deb435 Patrick Rudolph 2022-07-05 469 regulators[i].name);
38493f008deb435 Patrick Rudolph 2022-07-05 470 return PTR_ERR(rdev);
38493f008deb435 Patrick Rudolph 2022-07-05 471 }
38493f008deb435 Patrick Rudolph 2022-07-05 472 rdevs[i] = rdev;
38493f008deb435 Patrick Rudolph 2022-07-05 473 max597x->shunt_micro_ohms[i] = data->shunt_micro_ohms;
38493f008deb435 Patrick Rudolph 2022-07-05 474 }
38493f008deb435 Patrick Rudolph 2022-07-05 475
38493f008deb435 Patrick Rudolph 2022-07-05 @476 if (max597x->irq) {
38493f008deb435 Patrick Rudolph 2022-07-05 477 ret =
38493f008deb435 Patrick Rudolph 2022-07-05 478 max597x_setup_irq(max597x->dev, max597x->irq, rdevs, num_switches,
38493f008deb435 Patrick Rudolph 2022-07-05 479 data);
38493f008deb435 Patrick Rudolph 2022-07-05 480 if (ret) {
38493f008deb435 Patrick Rudolph 2022-07-05 481 dev_err(max597x->dev, "IRQ setup failed");
38493f008deb435 Patrick Rudolph 2022-07-05 482 return ret;
38493f008deb435 Patrick Rudolph 2022-07-05 483 }
38493f008deb435 Patrick Rudolph 2022-07-05 484 }
38493f008deb435 Patrick Rudolph 2022-07-05 485
38493f008deb435 Patrick Rudolph 2022-07-05 486 return ret;
38493f008deb435 Patrick Rudolph 2022-07-05 487 }
38493f008deb435 Patrick Rudolph 2022-07-05 488
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests