RE: [PATCH v2] rtlwifi: rtl8192se: Remove some unused variables

From: Ping-Ke Shih
Date: Wed Mar 01 2023 - 19:24:19 EST




> -----Original Message-----
> From: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> Sent: Wednesday, March 1, 2023 11:06 AM
> To: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> Cc: kvalo@xxxxxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx;
> linux-wireless@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Jiapeng Chong
> <jiapeng.chong@xxxxxxxxxxxxxxxxx>; Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Subject: [PATCH v2] rtlwifi: rtl8192se: Remove some unused variables

Miss subject prefix "wifi: ".

>
> Variable bcntime_cfg, bcn_cw and bcn_ifs are not effectively used, so
> delete it.
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1555:6: warning:
> variable 'bcntime_cfg' set but not used.
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4240
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>

Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>


> ---
> Changes in v2:
> -Remove bcn_cw and bcn_ifs.
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c
> index bd0b7e365edb..a8b5bf45b1bb 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c
> @@ -1552,8 +1552,6 @@ void rtl92se_set_beacon_related_registers(struct ieee80211_hw *hw)
> {
> struct rtl_priv *rtlpriv = rtl_priv(hw);
> struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
> - u16 bcntime_cfg = 0;
> - u16 bcn_cw = 6, bcn_ifs = 0xf;
> u16 atim_window = 2;
>
> /* ATIM Window (in unit of TU). */
> @@ -1576,13 +1574,6 @@ void rtl92se_set_beacon_related_registers(struct ieee80211_hw *hw)
> * other ad hoc STA */
> rtl_write_byte(rtlpriv, BCN_ERR_THRESH, 100);
>
> - /* Beacon Time Configuration */
> - if (mac->opmode == NL80211_IFTYPE_ADHOC)
> - bcntime_cfg |= (bcn_cw << BCN_TCFG_CW_SHIFT);
> -
> - /* TODO: bcn_ifs may required to be changed on ASIC */
> - bcntime_cfg |= bcn_ifs << BCN_TCFG_IFS;
> -
> /*for beacon changed */
> rtl92s_phy_set_beacon_hwreg(hw, mac->beacon_interval);
> }
> --
> 2.20.1.7.g153144c