Re: [PATCH RESEND net v1 0/2] iavf: fix double-broken HW hash report

From: Leon Romanovsky
Date: Thu Mar 02 2023 - 04:10:18 EST


On Wed, Mar 01, 2023 at 12:59:06PM +0100, Alexander Lobakin wrote:
> Currently, passing HW hash from descriptors to skb is broken two times.
> The first bug effectively disables hash from being filled at all, unless
> %NETIF_F_RXHASH is *disabled* via Ethtool. The second incorrectly says
> that IPv6 UDP packets are L3, which also triggers CPU hashing when
> needed (the networking core treats only L4 HW hash as "true").
> The very same problems were fixed in i40e and ice, but not in iavf,
> although each of the original commits bugged at least two drivers.
> It's never too late (I hope), so fix iavf this time.
>
> Alexander Lobakin (2):
> iavf: fix inverted Rx hash condition leading to disabled hash
> iavf: fix non-tunneled IPv6 UDP packet type and hashing
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>