Re: [RFC PATCH v11 08/12] net: ethernet: mtk_eth_soc: fix RX data corruption issue

[Vladimir Oltean]

On Thu, Mar 02, 2023 at 12:03:45AM +0000, Daniel Golle wrote:
> On Thu, Mar 02, 2023 at 01:31:21AM +0200, Vladimir Oltean wrote:
> > On Wed, Mar 01, 2023 at 07:55:05PM +0000, Daniel Golle wrote:
> > > Also set bit 12 which disabled the RX FIDO clear function when setting up
> > > MAC MCR, as MediaTek SDK did the same change stating:
> > > "If without this patch, kernel might receive invalid packets that are
> > > corrupted by GMAC."[1]
> > > This fixes issues with <= 1G speed where we could previously observe
> > > about 30% packet loss while the bad packet counter was increasing.
> > > 
> > > [1]: https://git01.mediatek.com/plugins/gitiles/openwrt/feeds/mtk-openwrt-feeds/+/d8a2975939a12686c4a95c40db21efdc3f821f63
> > > Tested-by: Bjørn Mork <bjorn@xxxxxxx>
> > > Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx>
> > > ---
> > 
> > Should this patch be submitted separately from the series, to the
> > net.git tree, to be backported to stable kernels?
> 
> Maybe yes, as this issue may affect e.g. the BPi-R3 board when used
> with 1G SFP modules. Previously this has just never been a problem as
> all practically all boards with MediaTek SoCs using SGMII also use the
> MediaTek MT7531 switch connecting in 2500Base-X mode.
> 
> Should the Fixes:-tag hence reference the commit adding support for the
> BPi-R3?

If it's not an issue that affects existing setups, there is no need to
backport the patch. But it needs to be clearly described as such in the
commit message.

You mention <= 1G speeds, but then only talk about 1G SFP modules.
I see that the mtk_eth_soc driver also sets "gmii" and "rgmii" in
phylink's supported_interfaces. Those are also <= 1G speeds. There could
also be SGMII on-board PHYs. Does the RX FIFO clearing issue not affect
those?