Re: [PATCH v2 0/3] leds: simatic-ipc-leds-gpio: split up

From: Henning Schild
Date: Thu Mar 02 2023 - 05:19:27 EST


Am Wed, 1 Mar 2023 19:30:38 +0200
schrieb Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>:

> On Wed, Mar 01, 2023 at 06:02:12PM +0100, Henning Schild wrote:
>
> > This series mainly splits the one GPIO driver into two. The split
> > allows to clearly model runtime and compile time dependencies on
> > the GPIO chip drivers.
> >
> > p1 is kind of not too related to that split but also prepares for
> > more GPIO based drivers to come.
> >
> > p2 takes the driver we had and puts some of its content into a
> > -core, to be used by the two drivers.
> >
> > p3 deals with more fine-grained configuration posibilities and
> > compile time dependencies.
> >
> > It is based on
> > [PATCH v4] leds: simatic-ipc-leds-gpio: make sure we have the GPIO
> > providing driver
>
> Thank you for an update.
> Not big issues found (except maybe the Makefile).
>

The Makefile does work with all Y. So if that was all that was open,
and the rest is just optional improvement. I would be happy if this can
be merged as is, and deal with improvements later.

Thanks!

Henning