Re: [RFC PATCH 07/16] dt-bindings: pinctrl: ralink: add new compatible strings
From: Krzysztof Kozlowski
Date: Thu Mar 02 2023 - 05:29:21 EST
On 02/03/2023 11:22, Arınç ÜNAL wrote:
>>>
>>> ## Incorrect naming
>>>
>>> MT7620, MT7621, MT7628, and MT7688 SoCs are incorrectly called Ralink,
>>> introduce new ralink->mediatek compatible strings to address it.
>>
>> So this part was addressed by Rob - we don't do it, because it does not
>> matter. Ralink is now Mediatek, thus there is no conflict and no issues
>> with different vendor used.
>
> I think Rob was rather addressing that updating compatible strings based
> on acquisition or marketing whims is not permitted. This condition does
> not apply here as these SoCs were never Ralink.
>
> I understand your point that Ralink is now MediaTek but still, calling
> these SoCs Ralink would be a bit misleading, don't you think?
Misleading yes, but also does not matter. At least matter not enough to
justify ABI break, so you would need to deprecate old ones and keep
everything backwards compatible. You still would affect 3rd party users
of DTS, though...
Best regards,
Krzysztof