Re: [PATCH v1 4/4] Revert "arm64: dts: mt8173: add mmsel clocks for 4K support"

From: Matthias Brugger
Date: Thu Mar 02 2023 - 06:04:00 EST




On 10/02/2023 12:59, AngeloGioacchino Del Regno wrote:
Il 09/02/23 17:03, matthias.bgg@xxxxxxxxxx ha scritto:
From: Matthias Brugger <matthias.bgg@xxxxxxxxx>

This reverts commit fc6634ac0e5380aeb1063275a2e9a583d41b2306.

The mmsys is a clock provider but does not have any clocks connected to
it. Therefore assigned-clock properties should be applied to the users of mmsys.

This fixes the DT schema check:
mediatek/mt8173-elm.dtb: syscon@14000000: 'assigned-clock-rates', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Matthias Brugger <matthias.bgg@xxxxxxxxx>

About solving schema checks: agreed.

Since this is impacting on multiple subsystems (display, vdec, venc), can we
instead move this to the topckgen node?
I didn't check if that would trigger another schema check, but I remember
doing that on Qualcomm DTs a bit of time ago.

The alternative would be to copy that over more than 10 nodes, which would
be a bit ... ugly.


Thanks Angelo and Chen-Yu for your feedback. I'm not able to reproduce that problem right now, so I'll drop this patch from the series.

Regards,
Matthias