Re: [PATCH 3/3] ASoC: maxim,max9867: add "mclk" support

From: Claudiu.Beznea
Date: Thu Mar 02 2023 - 07:46:01 EST


On 02.03.2023 14:20, Mark Brown wrote:
>> + max9867->mclk = devm_clk_get(&i2c->dev, "mclk");
>> + if (IS_ERR(max9867->mclk))
>> + return PTR_ERR(max9867->mclk);
>> + ret = clk_prepare_enable(max9867->mclk);
>> + if (ret < 0)
>> + dev_err(&i2c->dev, "Failed to enable MCLK: %d\n", ret);
>> +
> Nothing ever disables the clock - we need a disable in the remove path
> at least.

I don't have the full context of this patch but this diff seems a good
candidate for devm_clk_get_enabled().