Re: [PATCH v6] dt-bindings: leds: Document commonly used LED triggers
From: Manivannan Sadhasivam
Date: Fri Mar 03 2023 - 07:30:39 EST
On Fri, Mar 03, 2023 at 11:39:45AM +0000, Lee Jones wrote:
> On Fri, 03 Mar 2023, Lee Jones wrote:
>
> > On Mon, 13 Feb 2023, Manivannan Sadhasivam wrote:
> >
> > > Document the commonly used LED triggers by the SoCs. Not all triggers
> > > are documented as some of them are very application specific. Most of the
> > > triggers documented here are currently used in devicetrees of many SoCs.
> > >
> > > While at it, also place the comment above the triggers (hci, mmc, wlan)
> > > to match the rest of the binding.
> > >
> > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> > > ---
> > >
> > > Changes in v6:
> > >
> > > * Rebased on top of lee/for-leds-next branch
> > > * Fixed the comment location for few triggers
> > >
> > > Changes in v5:
> > >
> > > * Rebased on top of v6.2-rc1
> > >
> > > Changes in v4:
> > >
> > > * Removed the sorting of triggers
> > > * Removed the "items" as they were not needed
> > > * Reworded the description
> > > * Dropped Zhen Lei's tested-by tag as the patch has changed
> > > * Added kbd-capslock trigger
> > >
> > > Changes in v3:
> > >
> > > * Rebased on top of v6.1-rc1
> > > * Added WLAN Rx trigger
> > > * Added tested tag from Zhen Lei
> > >
> > > Changes in v2:
> > >
> > > * Added more triggers, fixed the regex
> > > * Sorted triggers in ascending order
> > >
> > > .../devicetree/bindings/leds/common.yaml | 37 +++++++++++++++++--
> > > 1 file changed, 34 insertions(+), 3 deletions(-)
> >
> > Applied, thanks
>
> Change of plan. This doesn't apply cleanly.
>
> Could you please rebase and resubmit please?
>
Done!
Thanks,
Mani
> --
> Lee Jones [李琼斯]
--
மணிவண்ணன் சதாசிவம்