Re: [PATCH 1/2] ALSA: ice1712: Do not left ice->gpio_mutex locked in aureon_add_controls()

[Takashi Iwai]

On Sat, 25 Feb 2023 19:43:21 +0100,
Dmitry Fomin wrote:
> 
> If snd_ctl_add() fails in aureon_add_controls(), it immediately returns
> and leaves ice->gpio_mutex locked. ice->gpio_mutex locks in
> snd_ice1712_save_gpio_status and unlocks in
> snd_ice1712_restore_gpio_status(ice).
> 
> It seems that the mutex is required only for aureon_cs8415_get(),
> so snd_ice1712_restore_gpio_status(ice) can be placed
> just after that. Compile tested only.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Dmitry Fomin <fomindmitriyfoma@xxxxxxx>

Applied both patches now.  Thanks.


Takashi