Re: [RFC PATCH 5/9] fuse: move fuse connection flags to the separate structure

From: Bernd Schubert
Date: Fri Mar 03 2023 - 13:27:12 EST




On 2/20/23 20:37, Alexander Mikhalitsyn wrote:
Let's move all the fuse connection flags that can be safely zeroed
after connection reinitialization to the separate structure fuse_conn_flags.

All of these flags values are calculated dynamically basing on
the userspace daemon capabilities (like no_open, no_flush) or on the
response for FUSE_INIT request.


From my point of view this makes the code a bit better readable, in general.

[...]

};
+/**
+ * A Fuse connection.
+ *
+ * This structure is created, when the root filesystem is mounted, and
+ * is destroyed, when the client device is closed and the last
+ * fuse_mount is destroyed.
+ */
+struct fuse_conn_flags {
+ /** Do readahead asynchronously? Only set in INIT */
+ unsigned async_read:1;


The comment does not match the struct?