Re: [PATCHv3 2/4] zsmalloc: fine-grained inuse ratio based fullness grouping

[Sergey Senozhatsky]

On (23/03/03 15:28), Andrew Morton wrote:
> Date: Fri, 3 Mar 2023 15:28:33 -0800
> From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> To: Yosry Ahmed <yosryahmed@xxxxxxxxxx>
> Cc: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>, Minchan Kim
>  <minchan@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx
> Subject: Re: [PATCHv3 2/4] zsmalloc: fine-grained inuse ratio based
>  fullness grouping
> Message-Id: <20230303152833.24d7a42102bd712e09f95cd5@xxxxxxxxxxxxxxxxxxxx>
> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
> 
> On Fri, 3 Mar 2023 08:58:55 -0800 Yosry Ahmed <yosryahmed@xxxxxxxxxx> wrote:
> 
> > > > +               for (fg = ZS_INUSE_RATIO_70; fg <= ZS_INUSE_RATIO_99; fg++)
> > > > +                       class_almost_full = zs_stat_get(class, fg);
> > > > +               for (fg = ZS_INUSE_RATIO_10; fg < ZS_INUSE_RATIO_70; fg++)
> > > > +                       class_almost_empty = zs_stat_get(class, fg);
> > >
> > > Aren't these supposed to be += ?

Good catch Yosry! Thanks for taking a look.

> I'll fix that up anyway, to avoid a bisection hole.  And in case [patch 4/4]
> gets dropped from the series or is later reverted or whatever.

Thanks Andrew, should I just send out a v4 with 3/4 and 4/4 fixed up?