Re: [PATCH v7 3/6] cxl/memdev: Add trigger_poison_list sysfs attribute

[Alison Schofield]

On Fri, Mar 03, 2023 at 03:42:45PM +0000, Jonathan Cameron wrote:
> On Fri, 17 Feb 2023 18:18:51 -0800
> alison.schofield@xxxxxxxxx wrote:
> 
> > From: Alison Schofield <alison.schofield@xxxxxxxxx>
> > 
> > When a boolean 'true' is written to this attribute the memdev driver
> > retrieves the poison list from the device. The list consists of
> > addresses that are poisoned, or would result in poison if accessed,
> > and the source of the poison. This attribute is only visible for
> > devices supporting the capability. The retrieved errors are logged
> > as kernel trace events with the label 'cxl_poison'.
> > 
> > Signed-off-by: Alison Schofield <alison.schofield@xxxxxxxxx>
> 
> Hi Alison,
> 
> The dates and version in the docs need an update. Otherwise
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>

Thanks Jonathan!

Fingers crossed for the March 2023 date!

> 
> > ---
> >  Documentation/ABI/testing/sysfs-bus-cxl | 14 +++++++
> >  drivers/cxl/core/memdev.c               | 56 +++++++++++++++++++++++++
> >  drivers/cxl/cxlmem.h                    |  2 +-
> >  3 files changed, 71 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/ABI/testing/sysfs-bus-cxl b/Documentation/ABI/testing/sysfs-bus-cxl
> > index 3acf2f17a73f..d9421c965a3b 100644
> > --- a/Documentation/ABI/testing/sysfs-bus-cxl
> > +++ b/Documentation/ABI/testing/sysfs-bus-cxl
> > @@ -415,3 +415,17 @@ Description:
> >  		1), and checks that the hardware accepts the commit request.
> >  		Reading this value indicates whether the region is committed or
> >  		not.
> > +
> > +
> > +What:		/sys/bus/cxl/devices/memX/trigger_poison_list
> > +Date:		November, 2022
> > +KernelVersion:	v6.2
> 
> Needs an update.
> 
> > +Contact:	linux-cxl@xxxxxxxxxxxxxxx
> > +Description: