Re: [PATCH 2/8] arm64: dts: qcom: msm8998-fxtec: correct GPIO keys wakeup

From: Konrad Dybcio
Date: Sat Mar 04 2023 - 07:57:10 EST




On 4.03.2023 13:33, Krzysztof Kozlowski wrote:
> gpio-keys,wakeup is a deprecated property:
>
> msm8998-fxtec-pro1.dtb: gpio-hall-sensors: event-hall-sensor1: Unevaluated properties are not allowed ('gpio-key,wakeup' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad
> arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts b/arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts
> index 5aad9f05780a..8b71b1f8f300 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts
> @@ -44,7 +44,7 @@ event-hall-sensor1 {
> label = "Keyboard Hall Sensor";
> gpios = <&tlmm 124 GPIO_ACTIVE_HIGH>;
> debounce-interval = <15>;
> - gpio-key,wakeup;
> + wakeup-source;
> linux,input-type = <EV_SW>;
> linux,code = <SW_KEYPAD_SLIDE>;
> };
> @@ -116,7 +116,7 @@ button-vol-up {
> gpios = <&pm8998_gpios 6 GPIO_ACTIVE_LOW>;
> linux,input-type = <EV_KEY>;
> linux,code = <KEY_VOLUMEUP>;
> - gpio-key,wakeup;
> + wakeup-source;
> debounce-interval = <15>;
> };
>