Re: [PATCH 4/8] arm64: dts: qcom: sc7280-idp: correct GPIO keys wakeup

From: Konrad Dybcio
Date: Sat Mar 04 2023 - 07:57:39 EST




On 4.03.2023 13:33, Krzysztof Kozlowski wrote:
> gpio-keys,wakeup is a deprecated property:
>
> sc7280-idp.dtb: gpio-keys: key-volume-up: Unevaluated properties are not allowed ('gpio-key,wakeup' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad
> arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> index cff0e0d31c15..b4b9d5e5cbd6 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> @@ -70,7 +70,7 @@ key-volume-up {
> gpios = <&pm7325_gpios 6 GPIO_ACTIVE_LOW>;
> linux,input-type = <1>;
> linux,code = <KEY_VOLUMEUP>;
> - gpio-key,wakeup;
> + wakeup-source;
> debounce-interval = <15>;
> linux,can-disable;
> };