Re: [PATCH 2/2] menuconfig: reclaim 1 more vertical line

From: Randy Dunlap
Date: Sat Mar 04 2023 - 12:55:17 EST


Hi,

On 3/4/23 08:56, Alexey Dobriyan wrote:
> Empty line after legend is waste, use it for config options.
>

I don't see an empty line after the legend. For me this patch
truncates the menu_instructions[] text from 4 lines to 3 lines,
dropping good/useful help text.

menu_instructions[] was already truncated before this patch
(in an 80x30 size terminal window).

What size terminal are you using?

> Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> ---
>
> scripts/kconfig/lxdialog/menubox.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/scripts/kconfig/lxdialog/menubox.c
> +++ b/scripts/kconfig/lxdialog/menubox.c
> @@ -185,7 +185,7 @@ int dialog_menu(const char *title, const char *prompt,
>
> height -= 2;
> width -= 5;
> - menu_height = height - 10;
> + menu_height = height - 9;
>
> max_choice = MIN(menu_height, item_count());
>

--
~Randy