Re: [PATCH v2 3/4] net: Let the active time stamping layer be selectable.

[Andrew Lunn]

> The timestamping part is via the netdev, which is a separate entity,
> and its that entity which is responsible for identifying which PHC it
> is connected to (normally by filling in the phc_index field of
> ethtool_ts_info.)
> 
> Think of is as:
> 
>   netdev ---- timestamping ---- PHC
> 
> since we can have:
> 
>   netdev1 ---- timestamping \
>   netdev2 ---- timestamping -*--- PHC
>   netdev3 ---- timestamping /
> 
> Since the ioctl is to do with requesting what we want the timestamping
> layer to be doing with packets, putting it in ptp_clock_info makes
> very little sense.

So there does not appear to be an object to represent a time stamper?

Should one be added? It looks like it needs two ops hwtstamp_set() and
hwtstamp_get(). It would then be registered with the ptp core. And
then the rest of what i said would apply...

	Andrew