Re: [PATCH] x86/kprobes: remove extern from arch_unoptimized_kprobes

[Google]

On Sat,  4 Mar 2023 09:15:44 -0500
Tom Rix <trix@xxxxxxxxxx> wrote:

> smatch reports
> arch/x86/kernel/kprobes/opt.c:537:13: warning:
>   function 'arch_unoptimize_kprobes' with external linkage has definition
> 
> extern is only needed in a declaration, so remove it.

Thanks for pointing it out! This looks good to me.

Acked-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>

Thanks, 

> 
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
> ---
>  arch/x86/kernel/kprobes/opt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/kprobes/opt.c b/arch/x86/kernel/kprobes/opt.c
> index 57b0037d0a99..1e699deb77fe 100644
> --- a/arch/x86/kernel/kprobes/opt.c
> +++ b/arch/x86/kernel/kprobes/opt.c
> @@ -534,8 +534,8 @@ void arch_unoptimize_kprobe(struct optimized_kprobe *op)
>   * Recover original instructions and breakpoints from relative jumps.
>   * Caller must call with locking kprobe_mutex.
>   */
> -extern void arch_unoptimize_kprobes(struct list_head *oplist,
> -				    struct list_head *done_list)
> +void arch_unoptimize_kprobes(struct list_head *oplist,
> +			     struct list_head *done_list)
>  {
>  	struct optimized_kprobe *op, *tmp;
>  
> -- 
> 2.27.0
> 


-- 
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>