Re: [PATCH] Revert "arm64: dts: ls1028a: sl28: get MAC addresses from VPD"

[Shawn Guo]

On Tue, Feb 07, 2023 at 02:10:20PM +0100, Michael Walle wrote:
> With commit b203e6f1e833 ("arm64: dts: ls1028a: sl28: get MAC addresses
> from VPD"), the network adapter now depends on the nvmem device to be
> present, which isn't the case and thus breaks networking on this board.
> Revert it.
> 
> Fixes: b203e6f1e833 ("arm64: dts: ls1028a: sl28: get MAC addresses from VPD")
> Signed-off-by: Michael Walle <michael@xxxxxxxx>

Applied!

> ---
> Shawn, unfortunately, the driver was NAKed, so this will break our
> KernelCI setup. Alternatively, the original commit can just be dropped
> from your tree, if that's how you do things like this. I've learned that
> the correct way is to get the driver in and then in the next release enable
> the driver and add it to the dts. Next time :)

Yes, please follow the correct way!

Shawn