Re: [PATCH v3] staging: vt6655: Macro with braces issue change to inline function

From: Deepak R Varma
Date: Mon Mar 06 2023 - 02:01:04 EST


On Mon, Mar 06, 2023 at 06:57:31AM +0100, Guru Mehar Rachaputi wrote:
> On Mon, Mar 06, 2023 at 11:06:06AM +0530, Deepak R Varma wrote:
> > On Mon, Mar 06, 2023 at 05:52:51AM +0100, Guru Mehar Rachaputi wrote:
> > > On Tue, Feb 07, 2023 at 01:49:15PM +0530, Deepak R Varma wrote:
> > >
> > > Hej Deepak,
> > >
> > > I have a problem in sending patchset through mutt.
> > > I have been trying sending to my own mail address but it won't work.
> >
> > This could be because of mutt configuration. There are some additional checks if
> > you are trying to use mutt with gmail. Search over google or lore old posts to
> > know more about it. The important aspect is to configure and test mutt well
> > before you use it for sending out patches.
> >
> > >
> > > When sending patchset I think we should use "In-Reply-To" flag and
> > > include "Message-ID" to which we want this to be in series to. I tried
> > > both "git send-email" feature and mutt "forwarding feature".
> >
> > I have not used "git send-email", so can't help you there. But mutt has worked
> > very well for me. Ensure you are reading and following the instructions from
> > this page well: https://kernelnewbies.org/Outreachyfirstpatch
> >
>
> So for example from these patches: 0.patch, 1.patch
> how to use "mutt -H" to send patches in one thread?
>
> if first one is: mutt -H 0.patch
> then should second one be: mutt -H 1.patch In-Reply-To: Message-ID?

Try this out by sending to yourself and you will know :)

There is a section "Using git format-patch to send patchsets" in the link I sent
in my last email. Please read that.

Deepak.

>
>
> > >
> > > Another issue is, how to attach patch file from inside mutt(for example:
> > > "mutt -H x.patch" from command line is used to extract header and body of a
> > > mail in mutt)?
> >
> > Why do you want to do that?
> > Build a patch file using "git format-patch" and then use "mutt -H" to send the
> > patch. Both the commands work directly from the command line. If there is a need
> > for any additional attachments in support of your patch [configs, logs, trace as
> > evidence, test outcomes etc], you can attach those from within the "mutt -H"
> > execution context.
> >
> > I suggest testing mutt well before you start sending any patches out by sending
> > the patches to yourself. Do not use any kernel mailing list for testing.
> >
> >
> > Regards,
> > Deepak.
> >
> > >
> > >
> > > --
> > > Thanks & Regards,
> > > Guru
> > >
> >
> >
>
> --
> Thanks & Regards,
> Guru
>