Re: [PATCH v2 4/5] ASoC: cs35l45: DSP Support

From: Charles Keepax
Date: Mon Mar 06 2023 - 04:27:12 EST


On Fri, Mar 03, 2023 at 01:21:50PM -0600, Vlad Karpovich wrote:
> From: "Vlad.Karpovich" <vkarpovi@xxxxxxxxxxxxxxxxxxxxx>
>
> The CS35L45 digital core incorporates one programmable DSP block,
> capable of running a wide range of audio enhancement and speaker
> and battery protection functions.
>
> Signed-off-by: Vlad Karpovich <vkarpovi@xxxxxxxxxxxxxxxxxxxxx>
> ---
> +#define CS35L45_DAC_MUX_ROUTE(name) \
> + { name" Source", "ASP_RX1", "ASP_RX1" }, \
> + { name" Source", "ASP_RX2", "ASP_RX2" }, \
> + { name" Source", "DSP_TX1", "DSP1" }, \
> + { name" Source", "DSP_TX2", "DSP1" }
> +
> +

Minor nit, double blank line here.

But otherwise looks pretty good to me:

Acked-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>

Thanks,
Charles