Re: [PATCH v2 13/23] interconnect: qcom: sm8550: fix registration race
From: Johan Hovold
Date: Mon Mar 06 2023 - 05:04:08 EST
On Mon, Mar 06, 2023 at 11:39:33AM +0200, Abel Vesa wrote:
> On 23-03-06 10:34:34, Johan Hovold wrote:
> > On Mon, Mar 06, 2023 at 11:03:14AM +0200, Abel Vesa wrote:
> > > On 23-03-06 08:56:41, Johan Hovold wrote:
> > > > The current interconnect provider registration interface is inherently
> > > > racy as nodes are not added until the after adding the provider. This
> > > > can specifically cause racing DT lookups to fail.
> > > >
> > > > Switch to using the new API where the provider is not registered until
> > > > after it has been fully initialised.
> > > >
> > > > Fixes: e6f0d6a30f73 ("interconnect: qcom: Add SM8550 interconnect provider driver")
> > > > Reviewed-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> > > > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> > > > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> > > > ---
> > >
> > > Any changes since v1 or is it just a resend?
> >
> > Please see the cover letter:
> >
> > https://lore.kernel.org/lkml/20230306075651.2449-1-johan+linaro@xxxxxxxxxx/
> >
> > Only the first patch of the series was updated in v2.
>
> Right, my bad. Though I wasn't CC'ed on that as well.
Yeah, sorry about that. I copied the CC list from v1 and forgot to make
sure that all reviewers were copied on the cover letter.
Johan